Refactor gen resources #984
Conversation
meta-cla
bot
added
the
CLA Signed
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM, the FFmpeg4 issue is known
Dumb Q, but why do we generate those test resources across all FFmpeg versions in our CI?
IIRC, we've only been using FFmpeg 4 for the reference generation so far?
|
@NicolasHug, good question. While we generated all of these resources originally with FFmpeg 4, they're actually stable across all versions we test against. For example, I've been using FFmpeg 6 for all of my testing the past several months, and when I re-run the resource generation script, everything comes out clean - we're bit-for-bit compatible with what we originally checked in. This may seem surprising at first, but if we expect TorchCodec to be bit-for-bit compatible across versions, it's not surprising if the I think we do have a comment somewhere about using FFmpeg 4. We should probably delete it, if we haven't already. |
2 participants
Two refactors:
generate_reference_resources.py, is now more deeply integrated with our testing utils. This allows us to greatly simplify the resource generation, and it keeps the actual definitions inutils.py. That is, the video we define inutils.pydefines the filename, and it has the logic for how to name reference frames.utils.pyso that we group all video and audio test files together.